Jesper Dangaard Brouer wrote:
On Sun, 2 Sep 2007, Patrick McHardy wrote:
This is not a ATM/ADSL only patch. This patch simply adds more
flexibility to the rate tables. Afterwards we can start the discussion
about how to use this new flexibility in tc/iproute2.
I know, but that discussion should happen *before* merging any
changes to the kernel.
Let not try to solve too many things at once. We need to do this in
small steps. Please, lets not start long and borrowing discussion
again, where we try to solve too many things at once.
We don't need many, but we do need *one* thing that actually
uses this and isn't controversial before merging.
Its pointless to add functionality that
won't be used afterwards or may need to be done differently.
I believe that the functionality _will_ be used, also in the general
case.
Lets focus on the general case, where the functionality actually is
needed right away.
In the general case:
- The rate table needs to be aligned (cell_align=-1).
(currently, we miscalculates up to 7 bytes on every lookup)
We will always do that, thats a consequence of storing the
transmission times for multiples of 8b.
- The existing tc overhead calc can be made more accurate.
(by adding overhead before doing the lookup, instead of the
current solution where the rate table is modified with its
limited resolution)
Please demonstrate this with patches (one for the overhead
calculation, one for the cell_align thing), then we can
continue this discussion.
Patrick, note that your STAB solution will _not_ work without the rate
table alignment.
I can't argue about this without looking into it again first,
but it shouldn't really matter for now since we don't have
a patch to actually implement it.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
