On Monday 27 August 2007 23:11:50 David Miller wrote:
> From: Joe Perches <[EMAIL PROTECTED]>
> Date: Mon, 27 Aug 2007 13:57:42 -0700
>
> > On Mon, 2007-08-27 at 13:41 -0700, David Miller wrote:
> > > From: Johannes Berg <[EMAIL PROTECTED]>
> > > Date: Mon, 27 Aug 2007 12:54:09 +0200
> > > > #define MAC_FMT "%s"
> > > > #define MAC_ARG(a) ({char __buf[18]; print_mac(a, __buf); __buf;})
> >
> > > I don't think this works.
> >
> > $ cat test_fmt.c
> > #include <stdio.h>
> > #include <stdlib.h>
>
> You're just getting lucky in this test case.
>
> The language does not allow what you are doing, so you're
> playing with fire.
What exactly to you think it invalid in this code?
I think it's fine (except that I'd chose an u8* for the mac
address (first arg in print_mac()).
--
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
