Andi Kleen wrote:
"Kok, Auke" <[EMAIL PROTECTED]> writes:
All,
Another update on e1000e. Many thanks to Jeff for helping out and
getting this going forward. The driver is unfortunately still too
large to post, so please use the URL's below to review:
Just some things I noticed; no comprehensive review
thanks, quick reply to one of the issues below, others I'll take into account
and look into deeper.
+ mod_timer(&adapter->blink_timer, jiffies + E1000_ID_INTERVAL);
Should use round_jiffies to avoid wakeups
actually, not here - we don't want the led to blink unreliably. If the timer
gets stalled beyond 1/2 a second and is irregular, you'll never be able to
identify the proper adapter port in you data center.
remember, this is only used once the user invokes 'ethtool -p'
Auke
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
