On Tue, Jul 31, 2007 at 01:23:29PM +0100, Christoph Hellwig ([EMAIL PROTECTED])
wrote:
> On Tue, Jul 31, 2007 at 02:20:51PM +0400, Evgeniy Polyakov wrote:
> > On Mon, Jul 30, 2007 at 06:50:28PM -0700, David Miller ([EMAIL PROTECTED])
> > wrote:
> > >
> > > Stephen Rothwell pointed out to me that the skb_frag_struct
> > > is broken on platforms using 64K or larger page sizes, it
> > > even generates warnings when (for example) the myri10ge driver
> > > tries to assign PAGE_SIZE into frag->size.
> > >
> > > I've thus increased page offset and size to __u32 in the patch below.
> >
> > Maybe wrap it into
> > #if PAGE_OFFSET > 12
> > #endif
> >
> > or something like that?
> >
> > I'm not sure actually why drivers would want to have list of 64k pages,
> > instead driver could call give_me_pages(size) instead of alloc_pages
> > and per-arch allocator would return one page or set of pages. This is a
> > handwaving for now...
>
> What about sendfile/splice on hugetlbfs?
offset in tcp_sendpage() ends up being poffset % PAGE_SIZE,
page is
struct page *page = pages[poffset / PAGE_SIZE];
So, as far as I understand, it will split bigpage into PAGE_SIZEd
chunks.
--
Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
