On Sat, 28 Jul 2007 17:44:45 +0200 Gabriel C <[EMAIL PROTECTED]> wrote:
> Hi, > > I got this compile error with a randconfig ( > http://194.231.229.228/MM/randconfig-auto-82.broken.netpoll.c ). > > ... > > net/core/netpoll.c: In function 'netpoll_poll': > net/core/netpoll.c:155: error: 'struct net_device' has no member named > 'poll_controller' > net/core/netpoll.c:159: error: 'struct net_device' has no member named > 'poll_controller' > net/core/netpoll.c: In function 'netpoll_setup': > net/core/netpoll.c:670: error: 'struct net_device' has no member named > 'poll_controller' > make[2]: *** [net/core/netpoll.o] Error 1 > make[1]: *** [net/core] Error 2 > make: *** [net] Error 2 > make: *** Waiting for unfinished jobs.... > > ... > > > I think is because KGDBOE selects just NETPOLL. > Looks like it. Select went and selected NETPOLL and NETPOLL_TRAP but things like CONFIG_NETDEVICES and CONFIG_NET_POLL_CONTROLLER remain unset. `select' remains evil. Something like this.. --- a/lib/Kconfig.kgdb~kgdb-kconfig-fix +++ a/lib/Kconfig.kgdb @@ -175,8 +175,7 @@ endchoice config KGDBOE tristate "KGDB: On ethernet" if !KGDBOE_NOMODULE depends on m && KGDB - select NETPOLL - select NETPOLL_TRAP + depends on NETPOLL_TRAP && NET_POLL_CONTROLLER help Uses the NETPOLL API to communicate with the host GDB via UDP. In order for this to work, the ethernet interface specified must _ - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html