On 7/12/07, Greg KH <[EMAIL PROTECTED]> wrote:
On Thu, Jul 12, 2007 at 10:59:53AM -0700, Yinghai Lu wrote: Please split this into two separate patches, as they are doing two different things. One for the driver core, and one for pci devices.
they need to applied together, otherwise all pci_dev numa_node will be change to device_add to -1 after pci_device_add.
Also, what kind of performance issues have you seen with this patch in place? As your previous patches were incorrect, I am guessing that you are not able to test this?
forcedeth on second node. without this patch in addition to get_mpbus_to_node patch, the numa_node is always 0. LBsuse91AMD64:/sys/devices/pci0000:80/0000:80:08.0 # cat numa_node 1 LBsuse91AMD64:/sys/devices/pci0000:80/0000:80:08.0 # cat net/eth2/numa_node 1 and after initialization LBsuse91AMD64:~ # tail -10 /var/log/messages Jul 13 03:05:16 LBsuse91AMD64 kernel: forcedeth 0000:00:08.0: YHLU gart_map_single - !need_iommu: ffff81011d33d010, 11d33d010, 670 Jul 13 03:05:26 LBsuse91AMD64 kernel: forcedeth 0000:00:08.0: YHLU gart_map_single - !need_iommu: ffff81011d322010, 11d322010, 670 Jul 13 03:05:29 LBsuse91AMD64 kernel: forcedeth 0000:00:08.0: YHLU gart_map_single - !need_iommu: ffff81011d33a810, 11d33a810, 670 Jul 13 03:05:31 LBsuse91AMD64 kernel: forcedeth 0000:00:08.0: YHLU gart_map_single - !need_iommu: ffff81011d33e810, 11d33e810, 670 Jul 13 03:05:31 LBsuse91AMD64 kernel: forcedeth 0000:00:08.0: YHLU gart_map_single - !need_iommu: ffff81011d358810, 11d358810, 670 Jul 13 03:05:31 LBsuse91AMD64 kernel: forcedeth 0000:00:08.0: YHLU gart_map_single - !need_iommu: ffff81011cfe1010, 11cfe1010, 670 Jul 13 03:05:31 LBsuse91AMD64 kernel: forcedeth 0000:00:08.0: YHLU gart_map_single - !need_iommu: ffff81011cfe1810, 11cfe1810, 670 Jul 13 03:05:31 LBsuse91AMD64 kernel: forcedeth 0000:00:08.0: YHLU gart_map_single - !need_iommu: ffff81011c7f9010, 11c7f9010, 670 Jul 13 03:05:31 LBsuse91AMD64 kernel: forcedeth 0000:00:08.0: YHLU gart_map_single - !need_iommu: ffff81011c7f9810, 11c7f9810, 670 Jul 13 03:05:34 LBsuse91AMD64 kernel: forcedeth 0000:00:08.0: YHLU gart_map_single - !need_iommu: ffff81011c2a7010, 11c2a7010, 670 gart_map_single is used all the time via netdev_alloc_skb for forcedth. YH - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
