On Thu, 2007-07-12 at 12:18 +0300, Ranko Zivojnovic wrote:
> >
> > I've done a bit of mess last time, so maybe it was forgotten, but I
> > still think this kind of race is possible:
> >
> > - gen_kill_estimator is called during qdisc_destroy under
> > dev->queue_lock,
> > - est_timer is running and waiting on this lock just on the
> > list entry of the destroyed class,
> > - gen_kill_estimator kills the entry and returns,
> > - in xxx_destroy_class kfree(cl) is done etc.,
> > - est_timer gets the lock and does nbytes = e->bstats->bytes or
> > e->rate_est-bps = ... with freed memory.
>
> Unfortunately I cannot say for sure that _currently_ anything really bad
> can happen here... someone with better knowledge will have to confirm
> this - Patrick?
>
Oops - just saw it - and you even mention it up there:
e->rate_est->bps = ...
^^^^
>
> Will have a new patch soon.
>
R.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
