> PJ Waskiewicz wrote:
> > +   /* If we're multiqueue, make sure the number of incoming bands
> > +    * matches the number of queues on the device we're 
> associating with.
> > +    */
> > +   if (tb[TCA_PRIO_MQ - 1])
> > +           q->mq = *(unsigned char *)RTA_DATA(tb[TCA_PRIO_MQ - 1]);
> > +
> > +   if (q->mq && (qopt->bands != sch->dev->egress_subqueue_count))
> > +           return -EINVAL;
> 
> 
> A nice thing you could do for the user here is use 
> egress_subqueue_count as default when qopt->bands == 0 (and 
> change tc prio to accept 0 in case it doesn't).

prio only allows a minimum of 2 bands right now.  I see what you're
suggesting though; let me think about this.  I do like this suggestion.

Thanks,
-PJ Waskiewicz
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to