On 11/3/25 10:33 PM, Jason Wang wrote: > On Tue, Nov 4, 2025 at 6:56 AM Daniel Jurgens <[email protected]> wrote: >> >> When probing a virtnet device, attempt to read the flow filter >> capabilities. In order to use the feature the caps must also >> be set. For now setting what was read is sufficient. >> >> Signed-off-by: Daniel Jurgens <[email protected]> >> Reviewed-by: Parav Pandit <[email protected]> >> Reviewed-by: Shahar Shitrit <[email protected]> >> >> --- >> v4: >> - Validate the length in the selector caps >> - Removed __free usage. >> - Removed for(int. >> v5: >> - Remove unneed () after MAX_SEL_LEN macro (test bot) >> v6: >> - Fix sparse warning "array of flexible structures" Jakub K/Simon H >> - Use new variable and validate ff_mask_size before set_cap. MST >> v7: >> - Set ff->ff_{caps, mask, actions} NULL in error path. Paolo Abeni >> - Return errors from virtnet_ff_init, -ENOTSUPP is not fatal. Xuan >> ---
>> + err = virtio_admin_cap_set(vdev, >> + VIRTIO_NET_FF_SELECTOR_CAP, >> + ff->ff_mask, >> + ff_mask_size); > > Should this be real_ff_mask_size? It can be. If the controller is sane they should be the same anyway. > > Thanks >
