On Tue, Jan 28, 2025 at 02:15:26PM +0100, Michal Luczaj wrote:
Series deals with two issues:
- socket reference count imbalance due to an unforgiving transport release
(triggered by transport reassignment);
- unintentional API feature, a failing connect() making the socket
impossible to use for any subsequent connect() attempts.
Luigi, I took the opportunity to comment vsock_bind() (patch 3/6), and I've
kept your Reviewed-by. Is this okay?
Hi Michal,
Yes, absolutely! Thanks for adding the comment :)
Cheers,
Luigi
Signed-off-by: Michal Luczaj <m...@rbox.co>
---
Changes in v3:
- Rebase
- Comment vsock_bind() (Luigi)
- Collect Reviewed-by (Stefano, Luigi)
- Link to v2:
https://lore.kernel.org/r/20250121-vsock-transport-vs-autobind-v2-0-aad6069a4...@rbox.co
Changes in v2:
- Introduce vsock_connect_fd(), simplify the tests, stick to SOCK_STREAM,
collect Reviewed-by (Stefano)
- Link to v1:
https://lore.kernel.org/r/20250117-vsock-transport-vs-autobind-v1-0-c802c8037...@rbox.co
---
Michal Luczaj (6):
vsock: Keep the binding until socket destruction
vsock: Allow retrying on connect() failure
vsock/test: Introduce vsock_bind()
vsock/test: Introduce vsock_connect_fd()
vsock/test: Add test for UAF due to socket unbinding
vsock/test: Add test for connect() retries
net/vmw_vsock/af_vsock.c | 13 ++++-
tools/testing/vsock/util.c | 88 +++++++++++-----------------
tools/testing/vsock/util.h | 2 +
tools/testing/vsock/vsock_test.c | 122 ++++++++++++++++++++++++++++++++++-----
4 files changed, 153 insertions(+), 72 deletions(-)
---
base-commit: 9e6c4e6b605c1fa3e24f74ee0b641e95f090188a
change-id: 20250116-vsock-transport-vs-autobind-2da49f1d5a0a
Best regards,
--
Michal Luczaj <m...@rbox.co>
