I tested this series of patches v6 with virtio-net regression tests, everything works fine.
Tested-by: Lei Yang <leiy...@redhat.com> On Wed, Jan 8, 2025 at 8:33 PM Michael S. Tsirkin <m...@redhat.com> wrote: > > On Mon, Dec 30, 2024 at 09:50:59AM +0000, Chia-Yu Chang (Nokia) wrote: > > >From: Jason Wang <jasow...@redhat.com> > > >Sent: Monday, December 30, 2024 8:52 AM > > >To: Chia-Yu Chang (Nokia) <chia-yu.ch...@nokia-bell-labs.com> > > >Cc: netdev@vger.kernel.org; dsah...@gmail.com; da...@davemloft.net; > > >eduma...@google.com; dsah...@kernel.org; pab...@redhat.com; > > >joel.grana...@kernel.org; k...@kernel.org; andrew+net...@lunn.ch; > > >ho...@kernel.org; pa...@netfilter.org; kad...@netfilter.org; > > >netfilter-de...@vger.kernel.org; coret...@netfilter.org; > > >shenjia...@huawei.com; salil.me...@huawei.com; shaoji...@huawei.com; > > >sae...@nvidia.com; tar...@nvidia.com; m...@redhat.com; > > >xuanz...@linux.alibaba.com; epere...@redhat.com; > > >virtualizat...@lists.linux.dev; i...@kernel.org; ncardw...@google.com; > > >Koen De Schepper (Nokia) <koen.de_schep...@nokia-bell-labs.com>; > > >g.wh...@cablelabs.com; ingemar.s.johans...@ericsson.com; > > >mirja.kuehlew...@ericsson.com; chesh...@apple.com; rs.i...@gmx.at; > > >jason_living...@comcast.com; vidhi_g...@apple.com > > >Subject: Re: [PATCH v6 net-next 11/14] virtio_net: Accurate ECN flag in > > >virtio_net_hdr > > > > > >[You don't often get email from jasow...@redhat.com. Learn why this is > > >important at https://aka.ms/LearnAboutSenderIdentification ] > > > > > >CAUTION: This is an external email. Please be very careful when clicking > > >links or opening attachments. See the URL nok.it/ext for additional > > >information. > > > > > > > > > > > >On Sat, Dec 28, 2024 at 3:13 AM <chia-yu.ch...@nokia-bell-labs.com> wrote: > > >> > > >> From: Chia-Yu Chang <chia-yu.ch...@nokia-bell-labs.com> > > >> > > >> Unlike RFC 3168 ECN, accurate ECN uses the CWR flag as part of the ACE > > >> field to count new packets with CE mark; however, it will be corrupted > > >> by the RFC 3168 ECN-aware TSO. Therefore, fallback shall be applied by > > >> seting NETIF_F_GSO_ACCECN to ensure that the CWR flag should not be > > >> changed within a super-skb. > > >> > > >> To apply the aforementieond new AccECN GSO for virtio, new featue bits > > >> for host and guest are added for feature negotiation between driver > > >> and device. And the translation of Accurate ECN GSO flag between > > >> virtio_net_hdr and skb header for NETIF_F_GSO_ACCECN is also added to > > >> avoid CWR flag corruption due to RFC3168 ECN TSO. > > >> > > >> Signed-off-by: Chia-Yu Chang <chia-yu.ch...@nokia-bell-labs.com> > > >> --- > > >> drivers/net/virtio_net.c | 14 +++++++++++--- > > >> drivers/vdpa/pds/debugfs.c | 6 ++++++ > > >> include/linux/virtio_net.h | 16 ++++++++++------ > > >> include/uapi/linux/virtio_net.h | 5 +++++ > > >> 4 files changed, 32 insertions(+), 9 deletions(-) > > > > > >Is there a link to the spec patch? It needs to be accepted first. > > > > > >Thanks > > > > Hi Jason, > > > > Thanks for the feedback, I found the virtio-spec in github: > > https://github.com/oasis-tcs/virtio-spec but not able to find the procedure > > to propose. > > Could you help to share the procedure to propose spec patch? Thanks. > > > You post it on virtio-comment for discussion. Github issues are then used > for voting and to track acceptance. > https://github.com/oasis-tcs/virtio-spec/blob/master/README.md#use-of-github-issues > > > > -- > > Chia-Yu > >
