Re: [PATCH net 3/4] virtio/vsock: Improve MSG_ZEROCOPY error handling

[Stefano Garzarella]

On Wed, Nov 06, 2024 at 06:51:20PM +0100, Michal Luczaj wrote:

Add a missing kfree_skb() to prevent memory leaks.

Fixes: 581512a6dc93 ("vsock/virtio: MSG_ZEROCOPY flag support")
Signed-off-by: Michal Luczaj <m...@rbox.co>
---
net/vmw_vsock/virtio_transport_common.c | 1 +
1 file changed, 1 insertion(+)

Reviewed-by: Stefano Garzarella <sgarz...@redhat.com>

diff --git a/net/vmw_vsock/virtio_transport_common.c 
b/net/vmw_vsock/virtio_transport_common.c
index 
cd075f608d4f6f48f894543e5e9c966d3e5f22df..e2e6a30b759bdc6371bb0d63ee2e77c0ba148fd2
 100644
--- a/net/vmw_vsock/virtio_transport_common.c
+++ b/net/vmw_vsock/virtio_transport_common.c
@@ -400,6 +400,7 @@ static int virtio_transport_send_pkt_info(struct vsock_sock 
*vsk,
                        if (virtio_transport_init_zcopy_skb(vsk, skb,
                                                            info->msg,
                                                            can_zcopy)) {
+                               kfree_skb(skb);
                                ret = -ENOMEM;
                                break;
                        }

--
2.46.2