> PJ Waskiewicz wrote: > > I did not modify other users of netif_queue_stopped() in > > net/core/netpoll.c, net/core/dev.c, or net/core/pktgen.c, since no > > classification occurs for the skb being sent to the device. > > Therefore, packets should always be ending up in queue 0, > so there's no need to check the subqueue status either. > > > > Thats not correct. Subqueue 0 may be full and the queue still running. > > I'll look over the patches later.
I'm working something up to address this. The last time I thought about this, I had issues with software devices, such as loopback. They weren't allocating any subqueues at all, so they would call netif_subqueue_stopped() and panic the kernel. However, now with Dave's request to index egress_subqueue, the first queue is allocated for everyone, so loopback and other software devices should be happy. Let me put these checks back in, test it out, and resend if I don't see any issues. Sorry for the thrash, -PJ Waskiewicz - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
