On Thu, 28 Mar 2024 16:05:02 +0800, Jason Wang <jasow...@redhat.com> wrote:
> On Wed, Mar 27, 2024 at 7:14 PM Xuan Zhuo <xuanz...@linux.alibaba.com> wrote:
> >
> > Now, the virtio core can set the premapped mode by find_vqs().
> > If the premapped can be enabled, the dma array will not be
> > allocated. So virtio-net use the api of find_vqs to enable the
> > premapped.
> >
> > Judge the premapped mode by the vq->premapped instead of saving
> > local variable.
> >
> > Signed-off-by: Xuan Zhuo <xuanz...@linux.alibaba.com>
> > ---
>
> I wonder what's the reason to keep a fallback when premapped is not enabled?

Rethink this.

I think you are right. We can remove the fallback.

Because we have the virtio dma apis that wrap all the cases.
So I will remove the fallback from the virtio-net in next version.

But we still need to export the premapped to the drivers.
Because we can enable the AF_XDP only when premapped is true.

Thanks


>
> Thanks
>

Reply via email to