> -----Original Message----- > From: Richard Cochran <richardcoch...@gmail.com> > Sent: 2021年4月18日 23:11 > To: Vladimir Oltean <olte...@gmail.com> > Cc: Y.b. Lu <yangbo...@nxp.com>; netdev@vger.kernel.org; Vladimir Oltean > <vladimir.olt...@nxp.com>; David S . Miller <da...@davemloft.net>; Jakub > Kicinski <k...@kernel.org>; Jonathan Corbet <cor...@lwn.net>; Kurt > Kanzenbach <k...@linutronix.de>; Andrew Lunn <and...@lunn.ch>; Vivien > Didelot <vivien.dide...@gmail.com>; Florian Fainelli <f.faine...@gmail.com>; > Claudiu Manoil <claudiu.man...@nxp.com>; Alexandre Belloni > <alexandre.bell...@bootlin.com>; unglinuxdri...@microchip.com; > linux-...@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: Re: [net-next 1/3] net: dsa: optimize tx timestamp request handling > > On Sun, Apr 18, 2021 at 12:18:42PM +0300, Vladimir Oltean wrote: > > > > How about not passing "clone" back to DSA as an argument by reference, > > but instead require the driver to populate DSA_SKB_CB(skb)->clone if > > it needs to do so? > > > > Also, how about changing the return type to void? Returning true or > > false makes no difference.
Thank you. That's good idea. And how about letting driver store the skb clone pointer, or not? I copied my comments in patch #3 here, " Can we totally drop dsa_skb_cb in dsa core? The only usage of it is holding a skb clone pointer, for only felix and sja1105. Actually we can move such pointer in <device>_skb_cb, instead of reserving the space of skb for any drivers." > > +1 > > Thanks, > Richard
