On Thu, Apr 15, 2021 at 07:27:50PM -0700, Jakub Kicinski wrote: > mlxsw has nicely grouped stats, add support for standard uAPI. > I'm guessing the register access part. Compile tested only.
Jakub, wanted to let you know that it seems to be working. I'll review the patches tomorrow/Sunday, as it's already late here. Thanks! $ ./ethtool -S swp13 --groups eth-phy eth-mac rmon Standard stats for swp13: eth-phy-SymbolErrorDuringCarrier: 0 eth-mac-FramesTransmittedOK: 8 eth-mac-FramesReceivedOK: 8 eth-mac-FrameCheckSequenceErrors: 0 eth-mac-AlignmentErrors: 0 eth-mac-OctetsTransmittedOK: 928 eth-mac-OctetsReceivedOK: 848 eth-mac-MulticastFramesXmittedOK: 8 eth-mac-BroadcastFramesXmittedOK: 0 eth-mac-MulticastFramesReceivedOK: 8 eth-mac-BroadcastFramesReceivedOK: 0 eth-mac-InRangeLengthErrors: 0 eth-mac-OutOfRangeLengthField: 0 eth-mac-FrameTooLongErrors: 0 rmon-etherStatsUndersizePkts: 0 rmon-etherStatsOversizePkts: 0 rmon-etherStatsFragments: 0 rmon-rx-etherStatsPkts64Octets: 0 rmon-rx-etherStatsPkts65to127Octets: 6 rmon-rx-etherStatsPkts128to255Octets: 2 rmon-rx-etherStatsPkts256to511Octets: 0 rmon-rx-etherStatsPkts512to1023Octets: 0 rmon-rx-etherStatsPkts1024to1518Octets: 0 rmon-rx-etherStatsPkts1519to2047Octets: 0 rmon-rx-etherStatsPkts2048to4095Octets: 0 rmon-rx-etherStatsPkts4096to8191Octets: 0 rmon-rx-etherStatsPkts8192to10239Octets: 0