From: Dan Carpenter <dan.carpen...@oracle.com>

The first argument of a WARN_ONCE() is a condition.  This WARN_ONCE()
will only print the table name, and is potentially problematic if the
table name has a %s in it.

Fixes: c520292f29b8 ("audit: log nftables configuration change events once per 
table")
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
Reviewed-by: Paul Moore <p...@paul-moore.com>
Signed-off-by: Pablo Neira Ayuso <pa...@netfilter.org>
---
 net/netfilter/nf_tables_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
index 005f1c620fc0..edb51c9ebab0 100644
--- a/net/netfilter/nf_tables_api.c
+++ b/net/netfilter/nf_tables_api.c
@@ -7978,7 +7978,7 @@ static void nf_tables_commit_audit_collect(struct 
list_head *adl,
                if (adp->table == table)
                        goto found;
        }
-       WARN_ONCE("table=%s not expected in commit list", table->name);
+       WARN_ONCE(1, "table=%s not expected in commit list", table->name);
        return;
 found:
        adp->entries++;
-- 
2.30.2

Reply via email to