On Thu, Apr 01, 2021 at 10:56:00AM -0700, Shannon Nelson wrote:
> @@ -1722,11 +1722,15 @@ static void ionic_txrx_free(struct ionic_lif *lif)
>  
>  static int ionic_txrx_alloc(struct ionic_lif *lif)
>  {
> -     unsigned int sg_desc_sz;
> +     unsigned int num_desc, desc_sz, comp_sz, sg_desc_sz;
>       unsigned int flags;
>       unsigned int i;

Coding Style nit: List of ints wants alphabetically order,
List can also fir 'flags' and 'i' with the others.

> @@ -2246,9 +2258,9 @@ static void ionic_swap_queues(struct ionic_qcq *a, 
> struct ionic_qcq *b)
>  int ionic_reconfigure_queues(struct ionic_lif *lif,
>                            struct ionic_queue_params *qparam)
>  {
> +     unsigned int num_desc, desc_sz, comp_sz, sg_desc_sz;
>       struct ionic_qcq **tx_qcqs = NULL;
>       struct ionic_qcq **rx_qcqs = NULL;
> -     unsigned int sg_desc_sz;
>       unsigned int flags;

Ditto.

Thanks,
Richard

Reply via email to