Ido Schimmel <ido...@idosch.org> writes:
> From: Ido Schimmel <ido...@nvidia.com>
>
> Cited commit changed the behavior of the software data path with regards
> to the ECN marking of decapsulated packets. However, the commit did not
> change other callers of __INET_ECN_decapsulate(), namely mlxsw. The
> driver is using the function in order to ensure that the hardware and
> software data paths act the same with regards to the ECN marking of
> decapsulated packets.
>
> The discrepancy was uncovered by commit 5aa3c334a449 ("selftests:
> forwarding: vxlan_bridge_1d: Fix vxlan ecn decapsulate value") that
> aligned the selftest to the new behavior. Without this patch the
> selftest passes when used with veth pairs, but fails when used with
> mlxsw netdevs.
>
> Fix this by instructing the device to propagate the ECT(1) mark from the
> outer header to the inner header when the inner header is ECT(0), for
> both NVE and IP-in-IP tunnels.
>
> A helper is added in order not to duplicate the code between both tunnel
> types.
>
> Fixes: b723748750ec ("tunnel: Propagate ECT(1) when decapsulating as
> recommended by RFC6040")
> Signed-off-by: Ido Schimmel <ido...@nvidia.com>
> Reviewed-by: Petr Machata <pe...@nvidia.com>
Huh, I had no idea there was a caller in the driver - thanks for fixing
that!
Acked-by: Toke Høiland-Jørgensen <t...@redhat.com>
