Stephen Hemminger wrote:
On Fri, 08 Jun 2007 16:42:31 -0700
"Kok, Auke" <[EMAIL PROTECTED]> wrote:
Stephen Hemminger wrote:
+#define ndev_printk(kern_level, netif_level, netdev, format, arg...) \
+ do { if ((netdev)->msg_enable & NETIF_MSG_##netif_level) { \
+ printk(kern_level "%s: " format, \
+ (netdev)->name, ## arg); } } while (0)
My preference would be something more like dev_printk or even use that?
You want to show both device name, and physical attachment in the message.
yes, agreed, but currently netdev->dev->bus_id is bluntly overwritten by
net-sysfs.c making this not trivial:
+471: strlcpy(dev->bus_id, net->name, BUS_ID_SIZE);
so now netdev->dev->bus_id contains eth%d as well. I vaguely remember that there
is another way to get the bus_id back, so I can likely work around it, but this
particular overwriting of information is a BUG imo, and should be fixed.
Auke
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
