On Thu, 25 Mar 2021 15:54:52 +0000 Russell King - ARM Linux admin <li...@armlinux.org.uk> wrote:
> The 88X3310 and 88X3340 can be differentiated by bit 3 in the revision. > In other words, 88X3310 is 0x09a0..0x09a7, and 88X3340 is > 0x09a8..0x09af. We could add a separate driver structure, which would > then allow the kernel to print a more specific string via standard > methods, like we do for other PHYs. Not sure whether that would work > for the 88X21x0 family though. According to release notes it seems that we can also differentiate 88E211X from 88E218X (via bit 3 in register 1.3): 88E211X has 0x09B9 88E218X has 0x09B1 but not 88E2110 from 88E2111 nor 88E2180 from 88E2181. These can be differentiated via register 3.0004.7 (bit 7 of MDIO_MMD_PCS.MDIO_SPEED., which says whether device is capable of 5g speed) I propose creating separate structures for mv88x3340 and mv88e218x. We can then print the remaining info as "(not) macsec/ptp capable" or "(not) 5g capable" What do you think? Marek