On Wed, Mar 24, 2021 at 06:11:57PM -0700, Jakub Kicinski wrote:
> struct ethtool_fecparam::reserved is never looked at by the core.
> Make sure it's actually 0. Unfortunately we can't return an error
> because old ethtool doesn't zero-initialize the structure for SET.
Hi Jakub
What makes it totally useless for future uses with SET. So the
documentation should probably be something like:
* @reserved: Reserved for future GET extensions.
*
* Older ethtool(1) leave @reserved uninitialised when calling SET or
* GET. Hence it can only be used to return a value to userspace with
* GET. Currently the value returned is guaranteed to be zero.
The rest looks O.K.
Andrew
