Alexander Duyck wrote: > This patch set is meant to be a cleanup and refactoring of common code bits > from several drivers. Specificlly a number of drivers engage in a pattern > where they will use some variant on an sprintf or memcpy to write a string > into the ethtool string array and then they will increment their pointer by > ETH_GSTRING_LEN. > > Instead of having each driver implement this independently I am refactoring > the code so that we have one central function, ethtool_sprintf that does > all this and takes a double pointer to access the data, a formatted string > to print, and the variable arguments that are associated with the string. > > Changes from v1: > Fixed usage of char ** vs unsigned char ** in hisilicon drivers > > Changes from RFC: > Renamed ethtool_gsprintf to ethtool_sprintf > Fixed reverse xmas tree issue in patch 2 >
Thanks Alex, I had a look over the whole thing and it looks good to me. Reviewed-by: Jesse Brandeburg <jesse.brandeb...@intel.com>
