On Wed, 2007-06-06 at 14:05 -0400, Jeff Garzik wrote: > On Wed, Jun 06, 2007 at 12:52:44PM -0500, wendy xiong wrote: > > On Sun, 2007-06-03 at 11:50 -0400, Jeff Garzik wrote: > > > Mithlesh Thukral wrote: > > > > NetXen: Add NETXEN prefix to a macro > > > > This patch will add the "NETXEN" prefix to "USER_START" macro. > > > > > > > > Signed-off by: Wen Xiong <[EMAIL PROTECTED]> > > > > Signed-off by: Mithlesh Thukral <[EMAIL PROTECTED]> > > > > --- > > > > > > > > drivers/net/netxen/netxen_nic.h | 4 ++-- > > > > drivers/net/netxen/netxen_nic_ethtool.c | 2 +- > > > > drivers/net/netxen/netxen_nic_hw.c | 4 ++-- > > > > drivers/net/netxen/netxen_nic_init.c | 4 ++-- > > > > 4 files changed, 7 insertions(+), 7 deletions(-) > > > > > > Your patch description is useless. Clearly we know -what- it does, > > > simply by reading the patch. > > > > > > But it does not answer the simple question: why? why is this needed in > > > a bug fix Release Candidate series? > > > > Hi Jeff, > > > > When we backported netxen driver to 2.6.9 kernel on ppc, we saw the > > compile errors for "USER_START". Because there is another definition for > > USER_START which is used by arch/ppc64/mm/hash_utils.c and native.c. > > > > So we like to add NETXEN before USER_START in netxen device driver, then > > netxen driver can be compiled correctly in 2.6.9 kernel. > > > > Let me know if you any question for this patch. > > That answers my questions, but doesn't address the issue: You need > to regenerate the patch with the description improved as described. > > The patch description is copied verbatim into the kernel changelog, and > preserved verbatim for all eternity. Four years from now, we need to be > able to read the patch description and understand -why- the NETXEN_xxx > prefix was added. Simply stating that the NETXEN_xxx prefix was added > is useless, as it is self-evident from reading the patch itself. > > Jeff > > > Jeff, Thanks. We will re-generate the patch with correct issue title and description.
Thanks, wendy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
