On Tue, 20 Oct 2020 at 04:14, Joel Stanley <j...@jms.id.au> wrote:
>
> On Mon, 19 Oct 2020 at 08:57, Dylan Hung <dylan_h...@aspeedtech.com> wrote:
> >
> > The interrupt handler may set the flag to reset the mac in the future,
> > but that flag is not cleared once the reset has occured.
> >
> > Fixes: 10cbd6407609 ("ftgmac100: Rework NAPI & interrupts handling")
> > Signed-off-by: Dylan Hung <dylan_h...@aspeedtech.com>
> > Signed-off-by: Joel Stanley <j...@jms.id.au>
>
> Reviewed-by: Joel Stanley <j...@jms.id.au>
net maintainers, this one never made it into the tree. Do you need me
to re-send it?
Cheers,
Joel
>
> > ---
> > drivers/net/ethernet/faraday/ftgmac100.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/ethernet/faraday/ftgmac100.c
> > b/drivers/net/ethernet/faraday/ftgmac100.c
> > index 0c67fc3e27df..57736b049de3 100644
> > --- a/drivers/net/ethernet/faraday/ftgmac100.c
> > +++ b/drivers/net/ethernet/faraday/ftgmac100.c
> > @@ -1326,6 +1326,7 @@ static int ftgmac100_poll(struct napi_struct *napi,
> > int budget)
> > */
> > if (unlikely(priv->need_mac_restart)) {
> > ftgmac100_start_hw(priv);
> > + priv->need_mac_restart = false;
> >
> > /* Re-enable "bad" interrupts */
> > ftgmac100_write(FTGMAC100_INT_BAD, priv->base +
> > FTGMAC100_OFFSET_IER);
> > --
> > 2.17.1
> >
