On Wed, May 30, 2007 at 03:57:13PM -0700, Kok, Auke wrote: > > Hmm, we're making a mess of it.
Indeed :) > Herbert, wouldn't it just have been a lot easier to do just add a > netif_poll_disable in e1000_probe, so that any and all other poll > enable/disables are symmetric ? Something like this? I wish if it were as simple as that. As soon as register_netdev returns somebody else can invoke e1000_open so disabling poll here can be undesirable. In fact the existing netif_stop_queue and netif_carrier_off calls are also bad for the same reason. I'll keep looking to see if there's some other problem that we haven't uncovered yet. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
