On 09/02/2021 12:32, Nikolay Aleksandrov wrote: > From: Ido Schimmel <ido...@nvidia.com> > > The bond driver needs to be patched to support new ethtool speeds. > Currently it emits a single warning [1] when it encounters an unknown > speed. As evident by the two previous patches, this is not explicit > enough. Instead, use WARN_ONCE() to get a more verbose warning [2]. > > [1] > bond10: (slave swp1): unknown ethtool speed (200000) for port 1 (set it to 0) > > [2] > bond20: (slave swp2): unknown ethtool speed (400000) for port 1 (set it to 0) > WARNING: CPU: 5 PID: 96 at drivers/net/bonding/bond_3ad.c:317 > __get_link_speed.isra.0+0x110/0x120 > Modules linked in: > CPU: 5 PID: 96 Comm: kworker/u16:5 Not tainted > 5.11.0-rc6-custom-02818-g69a767ec7302 #3243 > Hardware name: Mellanox Technologies Ltd. MSN4700/VMOD0010, BIOS 5.11 > 01/06/2019 > Workqueue: bond20 bond_mii_monitor > RIP: 0010:__get_link_speed.isra.0+0x110/0x120 > Code: 5b ff ff ff 52 4c 8b 4e 08 44 0f b7 c7 48 c7 c7 18 46 4a b8 48 8b 16 c6 > 05 d9 76 41 01 01 49 8b 31 89 44 24 04 e8 a2 8a 3f 00 <0f> 0b 8b 44 24 04 59 > c3 0 > f 1f 84 00 00 00 00 00 48 85 ff 74 3b 53 > RSP: 0018:ffffb683c03afde0 EFLAGS: 00010282 > RAX: 0000000000000000 RBX: ffff96bd3f2a9a38 RCX: 0000000000000000 > RDX: ffff96c06fd67560 RSI: ffff96c06fd57850 RDI: ffff96c06fd57850 > RBP: 0000000000000000 R08: ffffffffb8b49888 R09: 0000000000009ffb > R10: 00000000ffffe000 R11: 3fffffffffffffff R12: 0000000000000000 > R13: ffff96bd3f2a9a38 R14: ffff96bd49c56400 R15: ffff96bd49c564f0 > FS: 0000000000000000(0000) GS:ffff96c06fd40000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 00007f327ad804b0 CR3: 0000000142ad5006 CR4: 00000000003706e0 > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > Call Trace: > ad_update_actor_keys+0x36/0xc0 > bond_3ad_handle_link_change+0x5d/0xf0 > bond_mii_monitor.cold+0x1c2/0x1e8 > process_one_work+0x1c9/0x360 > worker_thread+0x48/0x3c0 > kthread+0x113/0x130 > ret_from_fork+0x1f/0x30 > > Signed-off-by: Ido Schimmel <ido...@nvidia.com> > --- > drivers/net/bonding/bond_3ad.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) >
Oops, forgot to add my acked-by. :) Acked-by: Nikolay Aleksandrov <niko...@nvidia.com>
