On Wed, May 23, 2007 at 04:34:18PM -0700, Chris Wright wrote: > > Mind adding an updated changelog and signed-off-by please?
Sure. [E1000]: Fix netif_poll_enable crash in e1000_open e1000_open calls e1000_up which will always call netif_poll_enable. However, it's illegal to call netif_poll_enable without calling netif_poll_disable at some prior time. This constraint is violated in e1000_open. This patch fixes it by simply calling netif_poll_disable in e1000_open. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c index b28a915..1e4e722 100644 --- a/drivers/net/e1000/e1000_main.c +++ b/drivers/net/e1000/e1000_main.c @@ -1423,6 +1423,7 @@ e1000_open(struct net_device *netdev) e1000_power_up_phy(adapter); + netif_poll_disable(netdev); if ((err = e1000_up(adapter))) goto err_up; adapter->mng_vlan_id = E1000_MNG_VLAN_NONE; - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
