On 2021-02-01 7:33 a.m., Simon Horman wrote:
On Fri, Jan 29, 2021 at 09:30:00AM -0500, Jamal Hadi Salim wrote:
Ido's comment is important: Why not make packet rate vs byte rate
mutually exclusive? If someone uses packet rate then you make sure
they dont interleave with attributes for byte rate and vice-versa.
Sorry, I somehow missed Ido's email until you and he pointed it out
in this thread.
This one i think is still important. Potential for misconfig
exists with both on.
The check for exclusivity is rather simple in init().
Also please see if you can add a test in the policer tests in tdc.
Regarding splitting up the policer action. I think there is some value to
the current setup in terms of code re-use and allowing combinations of
features. But I do agree it would be a conversation worth having at some
point.
Sounds reasonable.
cheers,
jamal
