On Wed, Jan 27, 2021 at 01:43:35PM +0200, stef...@marvell.com wrote: > if (priv->global_tx_fc && priv->hw_version != MVPP21) { > - val = mvpp2_cm3_read(priv, MSS_FC_COM_REG); > - val |= FLOW_CONTROL_ENABLE_BIT; > - mvpp2_cm3_write(priv, MSS_FC_COM_REG, val); > + err = mvpp2_enable_global_fc(priv); > + if (err) { > + dev_warn(&pdev->dev, "CM3 firmware not running, version > should be higher than 18.09\n"); > + dev_warn(&pdev->dev, "Flow control not supported\n"); > + }
I've just booted this on my mcbin-ss, and I get: mvpp2 f2000000.ethernet: CM3 firmware not running, version should be higher than 18.09 mvpp2 f4000000.ethernet: CM3 firmware not running, version should be higher than 18.09 which is rather odd, because I believe I'm running the 18.12 firmware from git://github.com/MarvellEmbeddedProcessors/binaries-marvell branch binaries-marvell-armada-18.12. Any ideas? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!