On Tue, Jan 26, 2021 at 10:27:53AM +0300, Dan Carpenter wrote: > > If you resend, can you please squash this diff on top of your patch? > > Yep. I will resend. Thanks for basically writing v2 for me. Your > review comments were very clear but code is always 100% clear so that's > really great.
Until the code is wrong :) > I've never seen anyone do that before. I should copy > that for my own reviews and hopefully it's a new trend. I took that from Florian, it was helpful to me when I wasn't minding my own business and touching code I couldn't test: https://patchwork.kernel.org/project/netdevbpf/patch/20201218223852.2717102-4-vladimir.olt...@nxp.com/#23858835 > > Also, it's strange but I don't see the v2 patches in patchwork. Did you > > send them in-reply-to v1 or something? > > I did send them as a reply to v1. Patchwork doesn't like that? Nope.
