On Friday 18 May 2007, Andrew Morton wrote: >On Fri, 18 May 2007 23:46:21 +0200 > >Mariusz Koz__owski <[EMAIL PROTECTED]> wrote: >> Hello, >> >> > diff --git a/drivers/net/smc91x.h b/drivers/net/smc91x.h >> > index 7053026..111f23d 100644 >> > --- a/drivers/net/smc91x.h >> > +++ b/drivers/net/smc91x.h >> > @@ -279,6 +279,40 @@ SMC_outw(u16 val, void __iomem *ioaddr, int reg) >> >> ... >> >> > +#define SMC_outb(v, a, r) __ __ >> > __outw(((inw((a)+((r)&~1))*(0xff<<8*(r%2)))) | ((v)<<(8*(r&2)))), (a) + >> > ((r)&~1)) >> >> This one has unbalanced parenthesis. > >I dunno how you can tell - I can't count that high. > Try removing the one in front of the comma, it makes the count -1. And I wrote, probably a good 20 years ago, a gizmo I called cntx that found that stuff for you. I occasionally use it to run over a section of the kernel tree, but it rarely finds anything to fuss about. And I really do need to make it handle shell expansions so you don't have write a quick script to have it scan everything in a directory. However I suspect that most of you already have such a tool in your bag of tricks.
>Can this be programmed in C, rather than in cpp? >- >To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >the body of a message to [EMAIL PROTECTED] >More majordomo info at http://vger.kernel.org/majordomo-info.html >Please read the FAQ at http://www.tux.org/lkml/ -- Cheers, Gene "There are four boxes to be used in defense of liberty: soap, ballot, jury, and ammo. Please use in that order." -Ed Howdershelt (Author) I'm definitely not in Omaha! - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html