On Fri, 22 Jan 2021 08:24:59 +0000 Ronak Doshi wrote:
> On 1/21/21, 5:07 PM, "Jakub Kicinski" <k...@kernel.org> wrote:
> > On Tue, 19 Jan 2021 18:19:40 -0800 Ronak Doshi wrote:
> > > + tq->buf_info = kmalloc_array_node(tq->tx_ring.size,
> > > sizeof(tq->buf_info[0]),
> > > + GFP_KERNEL | __GFP_ZERO,
> > > + dev_to_node(&adapter->pdev->dev));
> > > + if (!tq->buf_info) {
> > > + netdev_err(adapter->netdev, "failed to allocate tx buffer
> > > info\n")
> >
> > Please drop the message, OOM splat will be visible enough. checkpatch
> > usually points this out
>
> Okay, will drop it. Checkpatch did not complain about the error message
> though.
Looks like it matches alloc_node or alloc_array, but not
alloc_array_node ?
our $allocFunctions = qr{(?x:
(?:(?:devm_)?
(?:kv|k|v)[czm]alloc(?:_node|_array)? |
CCing Joe in case he thinks it's worth fixing
