On Wed, 2007-16-05 at 15:12 -0700, Sridhar Samudrala wrote: > Jamal, > > Here are some comments i have on your patch. > See them inline. >
Thanks for taking the time Sridhar. > try_tx_pkts() is directly calling the device's batch xmit routine. > Don't we need to call dev_hard_start_xmit() to handle dev_queue_xmit_nit > and GSO segmentation? > I think this is the core of all your other comments. Good catch - that piece of code has changed since 2.6.18; so the patch i posted wont work with GSO. You actually caught a bug in my other patch as well that nobody else did;-> I will have to think a bit about this; i may end up coalescing when grabbing the packets but call the nit from the driver using a helper. cheers, jamal - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
