On 1/18/21 1:58 PM, Jakub Kicinski wrote:
> But it does sound a little too much like aligning with the vendor
> driver for the sake of aligning with the vendor driver. This makes
> the review for someone not familiar with the vendor driver hard,
> and raises questions like "is this really needed upstream or just
> downstream / out-of-tree". Please try to reorient the work towards
> implementing particular pieces of functionality upstream start to end.
I have lots of this kind of preparatory work "ready to go" and I'm
eager to get it upstream. But I'll try to be more patient and wait
to send things out until something justifies the need, rather than
just doing it in support of a longer-term goal.
I would not consider what I'm doing "aligning with the vendor
driver," but maybe I misunderstand your meaning. The upstream
driver is very different from Qualcomm's driver. I'm basically
writing all new code now, using the Qualcomm code for reference.
Thank you very much for applying the patches.
-Alex
