Hey Boris, sorry for some delays on my end...

I saw some long discussions on this set with David, what is
the status here?


The main purpose of this series is to address these.

I'll take some more look into the patches, but if you
addressed the feedback from the last iteration I don't
expect major issues with this patch set (at least from
nvme-tcp side).

Changes since RFC v1:
=========================================
* Split mlx5 driver patches to several commits
* Fix nvme-tcp handling of recovery flows. In particular, move queue offlaod
    init/teardown to the start/stop functions.

I'm assuming that you tested controller resets and network hiccups
during traffic right?


Network hiccups were tested through netem packet drops and reordering.
We tested error recovery by taking the controller down and bringing it
back up while the system is quiescent and during traffic.

If you have another test in mind, please let me know.

I suggest to also perform interface down/up during traffic both
on the host and the targets.

Other than that we should be in decent shape...

Reply via email to