On Wed, Jan 13, 2021 at 01:45:16PM +0100, Gilles DOFFE wrote: > > This patchset fixes various issues. > It mainly concerns VLANs support by fixing FID table management to > allow adding more than one VLAN. > It also fixes tag/untag behavior on ingress/egress packets.
As far as I understand the series, it "fixes" something that was not broken (but which nonetheless could take some improvement), and does not fix something that was broken, because it was too broken. Good thing you brought up the bugs now, because FYI a tsunami is coming soon and it will cause major conflicts once Jakub merges net back into net-next. Had you waited a little bit longer, and the bug fixes sent to "net" would have not been backported too far down the line due to the API rework. https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=b7a9e0da2d1c954b7c38217a29e002528b90d174 You should try to find a reasonable balance between bugs due to an oversight, and "bugs" due to code which was put there as a joke more than anything else. Then you should send the fixes for the former to net and for the latter to net-next. Good luck.
