Eric Dumazet wrote: > From: Eric Dumazet <eduma...@google.com> > > napi_gro_receive() can never return GRO_DROP > > GRO_DROP can only be returned from napi_gro_frags() > which is the other NAPI GRO entry point. > > Followup patch will remove GRO_DROP, because drivers > are not supposed to call napi_gro_frags() if prior > napi_get_frags() has failed. > > Note that I have left the gro_dropped variable. I leave to ice > maintainers the decision to further remove it from ethtool -S results. > > Signed-off-by: Eric Dumazet <eduma...@google.com> > Cc: Jesse Brandeburg <jesse.brandeb...@intel.com>
Acked-by: Jesse Brandeburg <jesse.brandeb...@intel.com> Jakub or David, you're welcome to apply directly as part of this series. The original code went into the kernel right as the code to remove GRO_DROP returns went in just before, but the reviews crossed each other and no-one (especially me :-( ) caught it. for reference: commit 0e00c05fa72554c86d7c7e0f538ec83bfe277c91 Merge: b18e9834f7b2 045790b7bc66 Author: David S. Miller <da...@davemloft.net> Date: Thu Jun 25 16:16:21 2020 -0700 Subject: Merge branch 'napi_gro_receive-caller-return-value-cleanups'
