On Sun, 03 Jan 2021 11:47:46 +0100 Petr Machata <m...@pmachata.org> wrote:
> Stephen Hemminger <step...@networkplumber.org> writes: > > > On Sat, 2 Jan 2021 00:25:50 +0100 > > Petr Machata <m...@pmachata.org> wrote: > > > >> dcb currently sends all netlink messages with a type RTM_GETDCB, even the > >> set ones. Change to the appropriate type. > >> > >> Signed-off-by: Petr Machata <m...@pmachata.org> > >> --- > >> dcb/dcb.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/dcb/dcb.c b/dcb/dcb.c > >> index adec57476e1d..f5c62790e27e 100644 > >> --- a/dcb/dcb.c > >> +++ b/dcb/dcb.c > >> @@ -177,7 +177,7 @@ int dcb_set_attribute(struct dcb *dcb, const char > >> *dev, int attr, const void *da > >> struct nlattr *nest; > >> int ret; > >> > >> - nlh = dcb_prepare(dcb, dev, RTM_GETDCB, DCB_CMD_IEEE_SET); > >> + nlh = dcb_prepare(dcb, dev, RTM_SETDCB, DCB_CMD_IEEE_SET); > >> > >> nest = mnl_attr_nest_start(nlh, DCB_ATTR_IEEE); > >> mnl_attr_put(nlh, attr, data_len, data); > > > > Should I add fixes tag to this? > > Ha, I forgot that Fixes: tags are a thing in iproute2. Sorry about that, > I'll resend. Thanks, Fixes are mainly to help out distribution maintainers who want to backport to older versions.
