On Tue, 15 Dec 2020 11:09:21 +0100 Michal Kubecek wrote:
> On Tue, Dec 15, 2020 at 10:08:10AM +0100, Ivan Vecera wrote:
> > Fix two error paths in ethnl_set_channels() to avoid lock-up caused
> > but unreleased RTNL.
> >
> > Fixes: e19c591eafad ("ethtool: set device channel counts with CHANNELS_SET
> > request")
> > Cc: Michal Kubecek <mkube...@suse.cz>
> > Reported-by: LiLiang <li...@redhat.com>
> > Signed-off-by: Ivan Vecera <ivec...@redhat.com>
>
> Oh, the joys of mindless copy and paste... :-(
I wish sparse was able to catch rtnl_lock leaks. I tried to annotate
it a couple of weeks back but couldn't get it to work well even within
rtnetlink.c
> Reviewed-by: Michal Kubecek <mkube...@suse.cz>
Applied, thanks!
