On 10/12/2020 5:39, David Ahern wrote: > On 12/9/20 12:41 AM, Boris Pismenny wrote: > >> is applied there is relevant here. More generally, this offload is >> very similar in concept to TLS offload (tls_device). >> > > I disagree with the TLS comparison. As an example, AIUI the TLS offload > works with userspace sockets, and it is a protocol offload. >
First, tls offload can be used by kernel sockets just as userspace sockets. Second, it is not a protocol offload per-se, if you are looking for a carch-phrase to define it partial/autonomous offload is what I think fits better. IMO, the concepts are very similar, and those who implemented offload using the tls_device APIs will find this offload fits both hardware drivers naturally. To compare between them, please look at the NDOs, in particular the add/del/resync. Additionally, see the similarity between skb->ddp_crc and skb->decrypted. Also, consider the software-fallback flows used in both.
