Re: [PATCH net-next v5 08/14] net/smc: Introduce generic netlink interface for diagnostic purposes

[Jakub Kicinski]

On Tue, 24 Nov 2020 18:50:41 +0100 Karsten Graul wrote:
> From: Guvenc Gulce <guv...@linux.ibm.com>
> 
> Introduce generic netlink interface infrastructure to expose
> the diagnostic information regarding smc linkgroups, links and devices.
> 
> Signed-off-by: Guvenc Gulce <guv...@linux.ibm.com>
> Signed-off-by: Karsten Graul <kgr...@linux.ibm.com>

> @@ -2494,6 +2495,7 @@ static int __init smc_init(void)
>  
>       smc_ism_init();
>       smc_clc_init();
> +     smc_nl_init();

This can fail.

> +static const struct nla_policy smc_gen_nl_policy[SMC_GEN_MAX + 1] = {
> +     [SMC_GEN_UNSPEC]        = { .type = NLA_UNSPEC, },

This is unnecessary, NLA_UNSPEC is 0.

> +};