On Wed, 18 Nov 2020 15:20:10 -0800 David Awogbemila wrote: > Patch 1: Use u8 instead of bool for raw_addressing bit in gve_priv structure. > Simplify pointer arithmetic: use (option + 1) in gve_get_next_option. > Separate option parsing switch statement into individual function. > Patch 2: Use u8 instead of bool for raw_addressing bit in > gve_gve_rx_data_queue structure. > Correct typo in gve_desc.h comment (s/than/then/). > Change gve_rx_data_slot from struct to union. > Remove dma_mapping_error path change in gve_alloc_page - it should > probably be a bug fix. > Use & to obtain page address from data_ring->addr. > Move declarations of local variables i and slots to if statement > where they > are used within gve_rx_unfill_pages. > Simplify alloc_err path by using "while(i--)", eliminating need for > extra "int j" > variable in gve_prefill_rx_pages. > Apply byteswap to constant in gve_rx_flip_buff. > Remove gve_rx_raw_addressing as it does not do much more than > gve_rx_add_frags. > Remove stats update from elseif block, no need to optimize for > infrequent case of > work_done = 0. > Patch 3: Use u8 instead of bool for can_flip in gve_rx_slot_page_info. > Move comment in gve_rx_flip_buff to earlier, more relevant patch. > Fix comment wrap in gve_rx_can_flip_buffers. > Use ternary statement for gve_rx_can_flip_buffers. > Correct comment in gve_rx_qpl. > Patch 4: Use u8 instead of bool in gve_tx_ring structure. > Get rid of unnecessary local variable "dma" in > gve_dma_sync_for_device.
You need to start CCing people who gave you feedback, and discuss the feedback _before_ you send another version of the patchset. CCing Alex and Saeed
