>       case BR_STATE_DISABLED:
>               data |= PORT_LEARN_DISABLE;
> -             if (port < SWITCH_PORT_NUM)
> +             if (port < dev->phy_port_cnt)
>                       member = 0;
>               break;

So this, unlike all the other patches so far, is not obviously
correct. What exactly does phy_port_cnt mean? Can there be ports
without PHYs? What if the PHYs are external? You still need to be able
to change the STP state of such ports.

Andrew

Reply via email to