On 11/13/2020 3:48 PM, Shannon Nelson wrote:
> On 11/13/20 2:45 PM, Jacob Keller wrote:
>> -int ionic_firmware_update(struct ionic_lif *lif, const char *fw_name,
>> +int ionic_firmware_update(struct ionic_lif *lif, const struct firmware *fw,
>> struct netlink_ext_ack *extack)
>> {
>> struct ionic_dev *idev = &lif->ionic->idev;
>> @@ -99,24 +99,15 @@ int ionic_firmware_update(struct ionic_lif *lif, const
>> char *fw_name,
>> struct ionic *ionic = lif->ionic;
>> union ionic_dev_cmd_comp comp;
>> u32 buf_sz, copy_sz, offset;
>> - const struct firmware *fw;
>> struct devlink *dl;
>> int next_interval;
>> int err = 0;
>> u8 fw_slot;
>>
>> - netdev_info(netdev, "Installing firmware %s\n", fw_name);
>> -
>
> I prefer keeping the chatty little bits like this for debug purposes,
> but if you're going to remove it, then you should remove the matching
> netdev_info "Firmware update completed" message a few lines before the
> release_firmware().
>
> Aside from that, for the ionic bits:
> Acked-by: Shannon Nelson <snel...@pensando.io>
>
> Thanks,
> sln
>
So the only reason I removed this is because the function no longer has
access to the fw_name string. I'll change it to just remove the %s
format string.
