jamal wrote:
> I am keeping the thin 32 bit header, but other than that everything is
> in one TLV. SPD info one to follow..


I think using attributes here wasn't a bad idea since this exports
things that are implementation details and might need to be changed
or extended at some point.

>  enum xfrm_sadattr_type_t {
>       XFRMA_SAD_UNSPEC,
> -     XFRMA_SADHMASK,
> -     XFRMA_SADHMAX,
> -     XFRMA_SADCNT,
> +     XFRMA_SADINFO,
>       __XFRMA_SAD_MAX
>  
>  #define XFRMA_SAD_MAX (__XFRMA_SAD_MAX - 1)
>  };

In any case consistent naming here would be nice (SAD_ vs. SADXXX).
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to