On Thu, 12 Nov 2020 at 23:22, Jakub Kicinski <k...@kernel.org> wrote: > > On Thu, 12 Nov 2020 11:01:45 +1030 Joel Stanley wrote: > > When removing the driver we would hit > > BUG_ON(!list_empty(&dev->ptype_specific)) > > in net/core/dev.c due to still having the NC-SI packet handler > > registered. > > > Fixes: bd466c3fb5a4 ("net/faraday: Support NCSI mode") > > Signed-off-by: Joel Stanley <j...@jms.id.au> > > Thanks for the fix, I think there is another one of those missing in > the error path of ftgmac100_probe(), right? Under err_ncsi_dev?
You're correct, I'll send a v2.