On Thu, Nov 12, 2020 at 7:19 AM Edward Cree <ec...@solarflare.com> wrote: > > This series adds support for GRE and GRE_CSUM TSO on EF100 NICs, as > well as improving the handling of UDP tunnel TSO. > > Edward Cree (3): > sfc: extend bitfield macros to 19 fields > sfc: correctly support non-partial GSO_UDP_TUNNEL_CSUM on EF100 > sfc: support GRE TSO on EF100 > > drivers/net/ethernet/sfc/bitfield.h | 26 +++++++++++++++++++++----- > drivers/net/ethernet/sfc/ef100_nic.c | 8 ++++++-- > drivers/net/ethernet/sfc/ef100_tx.c | 12 ++++++++++-- > 3 files changed, 37 insertions(+), 9 deletions(-) >
The code itself is mostly solid. The only issue I see is a question I have about if we really need to be defining so many of the "EFX_POPULATE_..." macros in patch 1 as it seems a bit gratuitous and could likely be replaced by just adding multiple dummy fields to a single macro instead of defining multiple macros to get to the end goal. Reviewed-by: Alexander Duyck <alexanderdu...@fb.com>
