Jakub Sitnicki wrote: > On Thu, Nov 12, 2020 at 12:06 AM CET, Daniel Borkmann wrote: > > [...] > > >>> I'm not initimately familiar with this test, but looking at the change > >>> I'd consider that Destinations Options and encapsulation headers can > >>> follow the Fragment Header. > >>> > >>> With enough of Dst Opts or levels of encapsulation, transport header > >>> could be pushed to the 2nd fragment. So I'm not sure if the assertion > >>> from the IPv4 dissector that 2nd fragment and following doesn't contain > >>> any parseable header holds. > > > > Hm, staring at rfc8200, it says that the first fragment packet must include > > the upper-layer header (e.g. tcp, udp). The patch here should probably add a > > comment wrt to the rfc. > > You're right, it clearly says so. Nevermind my worries about malformed > packets then. Change LGTM: > > Reviewed-by: Jakub Sitnicki <ja...@cloudflare.com>
Also please add some of the details discussed here to the commit msg so we can remember this next time. Thanks!
