>> On Wed, Nov 11, 2020 at 03:24:33PM +0200, Grygorii Strashko wrote: >> > >> > Following Richard's comments v1 of the patch has to be applied [1]. >> > I've also added my Reviewed-by there. >> > >> > [1] https://lore.kernel.org/patchwork/patch/1334067/ >> >> +1 >> >> Jakub, can you please take the original v1 of this patch? > >I don't think v1 builds cleanly folks (not 100% sure, cpts is not >compiled on x86): > > ret = cpts->ptp_clock ? cpts->ptp_clock : (-ENODEV); > >ptp_clock is a pointer, ret is an integer, right?
yeah, I will modify like: ret = cpts->ptp_clock ? PTR_ERR(cpts->ptp_clock) : -ENODEV; > >Grygorii, would you mind sending a correct patch in so Wang Qing can >see how it's done? I've been asking for a fixes tag multiple times >already :( I still don't quite understand what a fixes tag means， can you tell me how to do this, thanks. Wang Qing
